[Intel-gfx] [PATCH v3 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form.

Winiarski, Michal michal.winiarski at intel.com
Thu Sep 17 10:17:24 PDT 2015


On śro, 2015-09-16 at 11:50 +0200, Michał Winiarski wrote:
> According to bspec, some parts of HW expect the addresses to be in
> a canonical form where bits [63:48] == [47].
> If we're using 32b addressing, we never need to handle such high
> addresses, but since we've recently added 48b address space support,
> lets satisfy the HW by converting the address prior to
> alloc/insert/clear.
> 
> v2: Commit msg update,
>     move WARN to gen8_alloc_va_range,
>     also convert to canonical in insert_entries.
> v3: Also convert for !48b (causes no harm, improves code stucture),
>     update wrap comment.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Michel Thierry <michel.thierry at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>

Actually... Please ignore this patch.
It's harmless, unfortunately it's also useless, and I need to address
this in a different way.
Sorry for the noise.

-Michał



More information about the Intel-gfx mailing list