[Intel-gfx] [PATCH 2/5] drm/i915: Notify user about outdated dmc firmware

Mika Kuoppala mika.kuoppala at linux.intel.com
Fri Sep 18 08:17:06 PDT 2015


If csr/dmc firmware is known to be outdated, notify
user.

Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 58edc3f..73807c3 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -45,6 +45,9 @@
 
 MODULE_FIRMWARE(I915_CSR_SKL);
 
+#define RECOMMENDED_FW_MAJOR		1
+#define RECOMMENDED_FW_MINOR		21
+
 /*
 * SKL CSR registers for DC5 and DC6
 */
@@ -387,6 +390,12 @@ static void finish_csr_load(const struct firmware *fw, void *context)
 
 	DRM_DEBUG_KMS("Finished loading %s v%u.%u\n", dev_priv->csr.fw_path,
 		      csr->dmc_ver_major, csr->dmc_ver_minor);
+
+	if (csr->dmc_ver_major < RECOMMENDED_FW_MAJOR ||
+	    csr->dmc_ver_minor < RECOMMENDED_FW_MINOR)
+		DRM_INFO("Outdated dmc firmware found, please upgrade to %u.%u or newer\n",
+			 RECOMMENDED_FW_MAJOR, RECOMMENDED_FW_MINOR);
+
 out:
 	if (fw_loaded)
 		intel_runtime_pm_put(dev_priv);
-- 
2.1.4



More information about the Intel-gfx mailing list