[Intel-gfx] [PATCH 1/5] drm/i915: Increase maximum polling time to 50ms for forcewake request/clear ack

Yu Dai yu.dai at intel.com
Mon Sep 21 09:43:06 PDT 2015


Looks fine to me.
Reviewed by: Alex Dai <yu.dai at intel.com>.

On 08/23/2015 05:22 AM, Sagar Arun Kamble wrote:
> On BXT, We Observe timeout for forcewake request completion with 2ms polling period as given here:
> [drm:fw_domains_get] ERROR render: timed out waiting for forcewake ack request.
> Polling for 50ms is recommended to avoid these timeouts.
>
> Change-Id: Ie715b0069a3049606e9602bc5e97a6511890864d
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_uncore.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 9d3c2e4..2df03b1 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -27,7 +27,7 @@
>   
>   #include <linux/pm_runtime.h>
>   
> -#define FORCEWAKE_ACK_TIMEOUT_MS 2
> +#define FORCEWAKE_ACK_TIMEOUT_MS 50
>   
>   #define __raw_i915_read8(dev_priv__, reg__) readb((dev_priv__)->regs + (reg__))
>   #define __raw_i915_write8(dev_priv__, reg__, val__) writeb(val__, (dev_priv__)->regs + (reg__))



More information about the Intel-gfx mailing list