[Intel-gfx] [PATCH] drm/i915: Do not update pipe state when crtc is inactive.

[Jani Nikula]

On Tue, 22 Sep 2015, Maarten Lankhorst <maarten.lankhorst at linux.intel.com> wrote:
> Nothing good can come from detaching scalers or updating pipe config
> when the crtc is already disabled. Touching registers while the crtc
> and power wells are disabled causes unclaimed register access warnings.

-fixes maintainer grumble. How am I supposed to decipher from this
Subject: line and commit message whether this is a real fix to a real
problem out there, and therefore to be queued for current -rc
development kernels and possibly cc: stable, or not?

When in doubt, I usually shrug it off, and decide it's for
drm-intel-next-queued, and therefore SEP.

BR,
Jani.


>
> Reported-by: Mika Kuoppala <mika.kuoppala at intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a4c24e6f5d6f..5a68290bf8c6 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13527,7 +13527,7 @@ static void intel_begin_crtc_commit(struct drm_crtc *crtc,
>  	/* Perform vblank evasion around commit operation */
>  	intel_pipe_update_start(intel_crtc);
>  
> -	if (modeset)
> +	if (modeset || !crtc->state->active)
>  		return;
>  
>  	if (to_intel_crtc_state(crtc->state)->update_pipe)
> -- 
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center