[Intel-gfx] [PATCH] drm/i915: Don't leak VBT mode data

[Daniel Vetter]

On Tue, Sep 15, 2015 at 10:50:45AM +0300, Jani Nikula wrote:
> On Tue, 15 Sep 2015, Matt Roper <matthew.d.roper at intel.com> wrote:
> > We allocate memory for LVDS modes while parsing the VBT at startup, but
> > never free this memory when the driver is unloaded, causing a small
> > leak.
> >
> > Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
> 
> We could probably use devm_*alloc functions for this kind of stuff more.

The problem with devm_* is that the lifetime of the underlying hw device
doesn't stricltly match the lifetime of the drm device. Not that anything
in drm gets that right (pretty far from it), but that's why I haven't gone
ballastic yet with rolling out devm_* all over our init code.
-Daniel

> 
> 
> > ---
> >  drivers/gpu/drm/i915/i915_dma.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> > index 066a0ef..c069550 100644
> > --- a/drivers/gpu/drm/i915/i915_dma.c
> > +++ b/drivers/gpu/drm/i915/i915_dma.c
> > @@ -1137,6 +1137,10 @@ int i915_driver_unload(struct drm_device *dev)
> >  		dev_priv->vbt.child_dev = NULL;
> >  		dev_priv->vbt.child_dev_num = 0;
> >  	}
> > +	kfree(dev_priv->vbt.sdvo_lvds_vbt_mode);
> > +	dev_priv->vbt.sdvo_lvds_vbt_mode = NULL;
> > +	kfree(dev_priv->vbt.lfp_lvds_vbt_mode);
> > +	dev_priv->vbt.lfp_lvds_vbt_mode = NULL;
> >  
> >  	vga_switcheroo_unregister_client(dev->pdev);
> >  	vga_client_register(dev->pdev, NULL, NULL, NULL);
> > -- 
> > 2.1.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch