[Intel-gfx] [PATCH 5/5] drm/i915: Propagating correct error codes to the userspace

Chris Wilson chris at chris-wilson.co.uk
Wed Sep 23 04:32:02 PDT 2015


On Wed, Sep 23, 2015 at 04:21:23PM +0530, ankitprasad.r.sharma at intel.com wrote:
> From: Ankitprasad Sharma <ankitprasad.r.sharma at intel.com>
> 
> Propagating correct error codes to userspace by using ERR_PTR and
> PTR_ERR macros for stolen memory based object allocation. We generally
> return -ENOMEM to the user whenever there is a failure in object
> allocation. This patch helps user to identify the correct reason for the
> failure and not just -ENOMEM each time.

This should be done before patch 3, so that the error progation is in
place before adding the possible EINTR.

Also note that the current i915_gem_object_alloc() itself can return
more than just ENOMEM and is worth expanding the possible error returns
as well.

Otherwise, lgtm.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list