[Intel-gfx] [PATCH] drm/i915: Defer adding preallocated stolen objects to the VM list

[Chris Wilson]

On Thu, Sep 24, 2015 at 10:02:00AM +0100, Chris Wilson wrote:
> When preallocating a stolen object during early initialisation, we may
> be running before we have setup the the global GTT VM state, in
> particular before we have initialised the range manager and associated
> lists. As this is the case, we defer binding the stolen object until we
> call i915_gem_setup_global_gtt(). Not only should we defer the binding,
> but we should also defer the VM list manipulation.
> 
> Fixes regression from commit a2cad9dff4dd44d0244b966d980de9d602d87593
> Author: Michał Winiarski <michal.winiarski at intel.com>
> Date:   Wed Sep 16 11:49:00 2015 +0200
> 
>     drm/i915/gtt: Do not initialize drm_mm twice.

For the record, this is not the root cause of the bug just the trigger
fr the current breakage. s/from/uncovered by/ ?
 
> Whilst I am here remove the duplicate work leaving dangling pointers
> from the error path...
> 
> Reported-by: Jesse Barnes <jesse at virtuousgeek.org>
Reported-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92099
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Jesse Barnes <jesse at virtuousgeek.org>
Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> Cc: Michel Thierry <michel.thierry at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> Cc: Michał Winiarski <michal.winiarski at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre