[Intel-gfx] [PATCH i-g-t] gem_storedw_loop: fix segfault when listing subtests
Thomas Wood
thomas.wood at intel.com
Thu Sep 24 03:13:14 PDT 2015
Commit fb66cd5 (tests/gem_storedw_loop: Fix use after free for bufmgr)
introduced a segmentation fault when listing subtests because
drm_intel_bufmgr_destroy is called with NULL. Move this and the call to
the close function inside an igt_fixture block to prevent them being
called when listing subtests.
Cc: Robert Beckett <robert.beckett at intel.com>
Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
Signed-off-by: Thomas Wood <thomas.wood at intel.com>
---
tests/gem_storedw_loop.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c
index e7ebcc2..e17e190 100644
--- a/tests/gem_storedw_loop.c
+++ b/tests/gem_storedw_loop.c
@@ -180,6 +180,8 @@ igt_main
}
}
- drm_intel_bufmgr_destroy(bufmgr);
- close(fd);
+ igt_fixture {
+ drm_intel_bufmgr_destroy(bufmgr);
+ close(fd);
+ }
}
--
1.9.1
More information about the Intel-gfx
mailing list