[Intel-gfx] [PATCH 07/12] drm/i915/bxt: Update stepping check for WaDisableSDEUnitClockGating

Arun Siluvery arun.siluvery at linux.intel.com
Mon Sep 28 04:09:15 PDT 2015


On 28/09/2015 12:06, Imre Deak wrote:
> On pe, 2015-09-25 at 14:33 +0100, Arun Siluvery wrote:
>> It is also applicable for B0.
>>
>> Signed-off-by: Arun Siluvery <arun.siluvery at linux.intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 9151a2b..be39f7ad 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -121,8 +121,10 @@ static void bxt_init_clock_gating(struct drm_device *dev)
>>   	gen9_init_clock_gating(dev);
>>
>>   	/* WaDisableSDEUnitClockGating:bxt */
>> -	I915_WRITE(GEN8_UCGCTL6, I915_READ(GEN8_UCGCTL6) |
>> -		   GEN8_SDEUNIT_CLOCK_GATE_DISABLE);
>> +	if (INTEL_REVID(dev) >= BXT_REVID_A0) {
>
> This check looks redundant.
>
Yes, I am removing it in v2.

regards
Arun

>> +		I915_WRITE(GEN8_UCGCTL6, (I915_READ(GEN8_UCGCTL6) |
>> +					  GEN8_SDEUNIT_CLOCK_GATE_DISABLE));
>> +	}
>>
>>   	/* WaSetHDCunitClckGatingDisable:bxt */
>>   	/* WaSetHdcUnitClockGatingDisableInUcgctl6:bxt */
>
>
>



More information about the Intel-gfx mailing list