[Intel-gfx] [PATCH 38/43] drm/i915: Parametrize AUX registes

[Daniel Vetter]

On Mon, Sep 28, 2015 at 03:15:18PM +0300, Jani Nikula wrote:
> On Fri, 18 Sep 2015, ville.syrjala at linux.intel.com wrote:
> > @@ -1012,35 +1012,16 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
> >  static uint32_t g4x_aux_ctl_reg(struct drm_i915_private *dev_priv,
> >  				enum port port)
> >  {
> > -	switch (port) {
> > -	case PORT_B:
> > -		return DPB_AUX_CH_CTL;
> > -	case PORT_C:
> > -		return DPC_AUX_CH_CTL;
> > -	case PORT_D:
> > -		return DPD_AUX_CH_CTL;
> > -	default:
> > -		MISSING_CASE(port);
> > -		return DPB_AUX_CH_CTL;
> > -	}
> > +	return DP_AUX_CH_CTL(port);
> 
> Together with the previous patch you now lose all MISSING_CASE/BUG/WARN
> for having an out-of-bounds/unsupported port. I kinda liked them.

MISSING_REG() to satisfy the typechecks would be good I think. Or
MISSING_CASE_REG().
-Danie
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch