[Intel-gfx] [drm-intel:for-linux-next-fixes 3/4] DockBook: drivers/gpu/drm/drm_probe_helper.c:107: warning: Excess function parameter 'dev' description in 'DRM_OUTPUT_POLL_PERIOD'
Daniel Vetter
daniel at ffwll.ch
Wed Sep 30 05:34:03 PDT 2015
On Wed, Sep 30, 2015 at 05:09:04PM +0800, kbuild test robot wrote:
> tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
> head: ad96c5f13442b17fafccc30f81efae2f08351f99
> commit: 10d3a5618b3aba24d6388ccdff2d0182b72a6e8d [3/4] drm: Add a non-locking version of drm_kms_helper_poll_enable(), v2
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
> drivers/gpu/drm/i915/i915_irq.c:491: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2217: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'wedged'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'fmt'
> include/drm/drm_crtc.h:310: warning: No description found for parameter 'mode_blob'
> include/drm/drm_crtc.h:748: warning: No description found for parameter 'tile_blob_ptr'
> include/drm/drm_crtc.h:787: warning: No description found for parameter 'rotation'
> include/drm/drm_crtc.h:883: warning: No description found for parameter 'mutex'
> include/drm/drm_crtc.h:883: warning: No description found for parameter 'helper_private'
> include/drm/drm_crtc.h:931: warning: Excess struct/union/enum/typedef member 'base' description in 'drm_bridge'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tile_idr'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'delayed_event'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'edid_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'dpms_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'path_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tile_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'plane_type_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'rotation_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_src_x'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_src_y'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_src_w'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_src_h'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_crtc_x'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_crtc_y'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_crtc_w'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_crtc_h'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_fb_id'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_crtc_id'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_active'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'prop_mode_id'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'dvi_i_subconnector_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'dvi_i_select_subconnector_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_subconnector_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_select_subconnector_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_mode_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_left_margin_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_right_margin_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_top_margin_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_bottom_margin_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_brightness_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_contrast_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_flicker_reduction_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_overscan_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_saturation_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'tv_hue_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'scaling_mode_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'aspect_ratio_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'dirty_info_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'suggested_x_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'suggested_y_property'
> include/drm/drm_crtc.h:1169: warning: No description found for parameter 'allow_fb_modifiers'
> Warning(include/drm/drm_modeset_lock.h:47): Incorrect use of kernel-doc format: * Contended lock: if a lock is contended you should only call
> Warning(include/drm/drm_modeset_lock.h:54): Incorrect use of kernel-doc format: * list of held locks (drm_modeset_lock)
> Warning(include/drm/drm_modeset_lock.h:59): Incorrect use of kernel-doc format: * Trylock mode, use only for panic handlers!
> Warning(include/drm/drm_modeset_lock.h:74): Incorrect use of kernel-doc format: * modeset lock
> Warning(include/drm/drm_modeset_lock.h:79): Incorrect use of kernel-doc format: * Resources that are locked as part of an atomic update are added
> >> drivers/gpu/drm/drm_probe_helper.c:107: warning: Excess function parameter 'dev' description in 'DRM_OUTPUT_POLL_PERIOD'
> >> drivers/gpu/drm/drm_probe_helper.c:107: warning: Excess function parameter 'dev' description in 'DRM_OUTPUT_POLL_PERIOD'
I think this should be fixed by moving the DRM_OUTPUT_POLL_PERIOD #define
before the kerneldoc for drm_kms_helper_poll_enable_locked. Jani, can you
please do that fixup and check that make htmldocs is happy with it?
Thanks, Daniel
> include/drm/drm_dp_helper.h:702: warning: No description found for parameter 'i2c_nack_count'
> include/drm/drm_dp_helper.h:702: warning: No description found for parameter 'i2c_defer_count'
> drivers/gpu/drm/drm_dp_mst_topology.c:2211: warning: No description found for parameter 'connector'
> include/drm/drm_dp_mst_helper.h:97: warning: No description found for parameter 'cached_edid'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'max_dpcd_transaction_bytes'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'sink_count'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'total_slots'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'avail_slots'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'total_pbn'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'qlock'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'tx_msg_downq'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'tx_msg_upq'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'tx_down_in_progress'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'tx_up_in_progress'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'payload_lock'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'proposed_vcpis'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'payloads'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'payload_mask'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'vcpi_mask'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'tx_waitq'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'work'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'tx_work'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'destroy_connector_list'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'destroy_connector_lock'
> include/drm/drm_dp_mst_helper.h:470: warning: No description found for parameter 'destroy_connector_work'
> drivers/gpu/drm/drm_dp_mst_topology.c:2211: warning: No description found for parameter 'connector'
> include/drm/drmP.h:164: warning: No description found for parameter 'fmt'
> include/drm/drmP.h:180: warning: No description found for parameter 'fmt'
> include/drm/drmP.h:198: warning: No description found for parameter 'fmt'
> include/drm/drmP.h:238: warning: No description found for parameter 'dev'
> include/drm/drmP.h:238: warning: No description found for parameter 'data'
> include/drm/drmP.h:238: warning: No description found for parameter 'file_priv'
> include/drm/drmP.h:271: warning: No description found for parameter 'ioctl'
> include/drm/drmP.h:271: warning: No description found for parameter '_func'
> include/drm/drmP.h:271: warning: No description found for parameter '_flags'
> include/drm/drmP.h:344: warning: cannot understand function prototype: 'struct drm_lock_data '
> include/drm/drmP.h:397: warning: cannot understand function prototype: 'struct drm_driver '
> include/drm/drmP.h:646: warning: cannot understand function prototype: 'struct drm_info_list '
> include/drm/drmP.h:656: warning: cannot understand function prototype: 'struct drm_info_node '
> include/drm/drmP.h:666: warning: cannot understand function prototype: 'struct drm_minor '
> include/drm/drmP.h:712: warning: cannot understand function prototype: 'struct drm_device '
> drivers/gpu/drm/i915/i915_irq.c:491: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2217: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'wedged'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'fmt'
> drivers/gpu/drm/i915/i915_irq.c:491: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2217: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'wedged'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'fmt'
> drivers/gpu/drm/i915/i915_irq.c:491: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2217: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'wedged'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'fmt'
> drivers/gpu/drm/i915/i915_irq.c:491: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2217: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'wedged'
> drivers/gpu/drm/i915/i915_irq.c:2397: warning: No description found for parameter 'fmt'
> drivers/gpu/drm/i915/i915_gem.c:421: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:421: warning: No description found for parameter 'data'
> drivers/gpu/drm/i915/i915_gem.c:421: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:686: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:686: warning: No description found for parameter 'data'
> drivers/gpu/drm/i915/i915_gem.c:686: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:767: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:767: warning: No description found for parameter 'obj'
> drivers/gpu/drm/i915/i915_gem.c:767: warning: No description found for parameter 'args'
> drivers/gpu/drm/i915/i915_gem.c:767: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:1027: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:1027: warning: No description found for parameter 'data'
> drivers/gpu/drm/i915/i915_gem.c:1027: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:1192: warning: No description found for parameter 'rps'
> drivers/gpu/drm/i915/i915_gem.c:1398: warning: No description found for parameter 'req'
> drivers/gpu/drm/i915/i915_gem.c:1433: warning: No description found for parameter 'obj'
> drivers/gpu/drm/i915/i915_gem.c:1433: warning: No description found for parameter 'readonly'
> drivers/gpu/drm/i915/i915_gem.c:1556: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:1556: warning: No description found for parameter 'data'
> drivers/gpu/drm/i915/i915_gem.c:1556: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:1619: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:1619: warning: No description found for parameter 'data'
> drivers/gpu/drm/i915/i915_gem.c:1619: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:1664: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:1664: warning: No description found for parameter 'data'
> drivers/gpu/drm/i915/i915_gem.c:1664: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vma'
> drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vmf'
> drivers/gpu/drm/i915/i915_gem.c:1952: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:1952: warning: No description found for parameter 'size'
> drivers/gpu/drm/i915/i915_gem.c:1952: warning: No description found for parameter 'tiling_mode'
> drivers/gpu/drm/i915/i915_gem.c:1952: warning: No description found for parameter 'fenced'
> drivers/gpu/drm/i915/i915_gem.c:1952: warning: Excess function parameter 'obj' description in 'i915_gem_get_gtt_alignment'
> drivers/gpu/drm/i915/i915_gem.c:2815: warning: No description found for parameter 'ring'
> drivers/gpu/drm/i915/i915_gem.c:2944: warning: No description found for parameter 'obj'
> drivers/gpu/drm/i915/i915_gem.c:2994: warning: No description found for parameter 'dev'
> drivers/gpu/drm/i915/i915_gem.c:2994: warning: No description found for parameter 'data'
> drivers/gpu/drm/i915/i915_gem.c:2994: warning: No description found for parameter 'file'
> drivers/gpu/drm/i915/i915_gem.c:2994: warning: Excess function parameter 'DRM_IOCTL_ARGS' description in 'i915_gem_wait_ioctl'
> drivers/gpu/drm/i915/i915_gem.c:3355: warning: No description found for parameter 'obj'
> drivers/gpu/drm/i915/i915_gem.c:3355: warning: No description found for parameter 'vm'
> drivers/gpu/drm/i915/i915_gem.c:3355: warning: No description found for parameter 'ggtt_view'
> drivers/gpu/drm/i915/i915_gem.c:3355: warning: No description found for parameter 'alignment'
>
> vim +107 drivers/gpu/drm/drm_probe_helper.c
>
> eaf99c74 Chris Wilson 2014-08-06 91
> eaf99c74 Chris Wilson 2014-08-06 92 drm_mode_probed_add(connector, mode);
> eaf99c74 Chris Wilson 2014-08-06 93 return 1;
> eaf99c74 Chris Wilson 2014-08-06 94 }
> eaf99c74 Chris Wilson 2014-08-06 95
> 10d3a561 Egbert Eich 2015-09-23 96 /**
> 10d3a561 Egbert Eich 2015-09-23 97 * drm_kms_helper_poll_enable_locked - re-enable output polling.
> 10d3a561 Egbert Eich 2015-09-23 98 * @dev: drm_device
> 10d3a561 Egbert Eich 2015-09-23 99 *
> 10d3a561 Egbert Eich 2015-09-23 100 * This function re-enables the output polling work without
> 10d3a561 Egbert Eich 2015-09-23 101 * locking the mode_config mutex.
> 10d3a561 Egbert Eich 2015-09-23 102 *
> 10d3a561 Egbert Eich 2015-09-23 103 * This is like drm_kms_helper_poll_enable() however it is to be
> 10d3a561 Egbert Eich 2015-09-23 104 * called from a context where the mode_config mutex is locked
> 10d3a561 Egbert Eich 2015-09-23 105 * already.
> 10d3a561 Egbert Eich 2015-09-23 106 */
> 8c4ccc4a Daniel Vetter 2015-07-09 @107 #define DRM_OUTPUT_POLL_PERIOD (10*HZ)
> 10d3a561 Egbert Eich 2015-09-23 108 void drm_kms_helper_poll_enable_locked(struct drm_device *dev)
> 8c4ccc4a Daniel Vetter 2015-07-09 109 {
> 8c4ccc4a Daniel Vetter 2015-07-09 110 bool poll = false;
> 8c4ccc4a Daniel Vetter 2015-07-09 111 struct drm_connector *connector;
> 8c4ccc4a Daniel Vetter 2015-07-09 112
> 8c4ccc4a Daniel Vetter 2015-07-09 113 WARN_ON(!mutex_is_locked(&dev->mode_config.mutex));
> 8c4ccc4a Daniel Vetter 2015-07-09 114
> 8c4ccc4a Daniel Vetter 2015-07-09 115 if (!dev->mode_config.poll_enabled || !drm_kms_helper_poll)
>
> :::::: The code at line 107 was first introduced by commit
> :::::: 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f drm/probe-helper: Grab mode_config.mutex in poll_init/enable
>
> :::::: TO: Daniel Vetter <daniel.vetter at ffwll.ch>
> :::::: CC: Daniel Vetter <daniel.vetter at ffwll.ch>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the Intel-gfx
mailing list