[Intel-gfx] [PATCH 0/4] Enable FBC on SKL, v3

Thulasimani, Sivakumar sivakumar.thulasimani at intel.com
Wed Apr 6 05:06:21 UTC 2016


dont want to hijack thread but wanted to point out a possible regression 
in the
previous patches of this series.

intel_fbc_can_choose: returns true for gen 4/5/6/7. (possible bug)

so intel_crtc_state->enable_fbc = true; will be executed for first crtc
everytime intel_fbc_choose_crtc is called. Although there is check to
handle fbc already enabled, it may fail when we fbc is disabled and
we are working on non supported panel.

regards,
Sivakumar

On 4/5/2016 2:47 AM, Paulo Zanoni wrote:
> Now with the suggestion from Chris instead of the old workaround. We don't need
> new DDX patches anymore, but now we need new IGT patches.
>
> Chris Wilson (1):
>    drm/i915: use ORIGIN_CPU for frontbuffer invalidation on WC mmaps
>
> Paulo Zanoni (3):
>    drm/i915/fbc: update busy_bits even for GTT and flip flushes
>    drm/i915/fbc: sanitize i915.enable_fbc during FBC init
>    drm/i915/fbc: enable FBC on gen 9+ too
>
>   drivers/gpu/drm/i915/i915_drv.h  |  1 +
>   drivers/gpu/drm/i915/i915_gem.c  | 14 +++++++++++---
>   drivers/gpu/drm/i915/intel_fbc.c | 27 ++++++++++++++++-----------
>   3 files changed, 28 insertions(+), 14 deletions(-)
>



More information about the Intel-gfx mailing list