[Intel-gfx] [PATCH] drm/i915: Only grab correct forcewake for the engine with execlists

[Chris Wilson]

On Wed, Apr 06, 2016 at 03:49:55PM +0100, Tvrtko Ursulin wrote:
> +static const i915_reg_t gen9_shadowed_regs[] = {
> +	RING_TAIL(RENDER_RING_BASE),
> +	RING_TAIL(GEN6_BSD_RING_BASE),
> +	RING_TAIL(VEBOX_RING_BASE),
> +	RING_TAIL(BLT_RING_BASE),

It occurs to me that we will never use these in anger and so can drop
from the search table.

> +	FORCEWAKE_BLITTER_GEN9,
> +	FORCEWAKE_RENDER_GEN9,
> +	FORCEWAKE_MEDIA_GEN9,

These always use raw accessors (internal to intel_uncore.c).

> +	GEN6_RPNSWREQ,

Always written in conjunction with other registers notable by their
absence from this table

> +	GEN6_RC_VIDEO_FREQ,

Used once per load/resume/reset, whoop-a-do.

> +	/* TODO: Other registers are not yet used */

I hope there are more magic registers that we actually use.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre