[Intel-gfx] [PATCH i-g-t v2] test/gem_mocs_settings: Testing MOCS register settings
Peter Antoine
peter.antoine at intel.com
Mon Apr 11 13:15:01 UTC 2016
On Mon, 11 Apr 2016, Chris Wilson wrote:
> On Mon, Apr 11, 2016 at 01:50:16PM +0100, Peter Antoine wrote:
>> On Fri, 8 Apr 2016, Chris Wilson wrote:
>>>> + execbuf.flags = I915_EXEC_SECURE | engine_id;
>>>> +
>>>> + gem_execbuf(fd, &execbuf);
>>>> + gem_sync(fd, handle);
>>>
>>> ^ Papering over a bug in your code.
>>>
>>> Hint: did you tell anyone that you were writing into the buffer?
>> Ok a write_domain and gem_wait.
>
> gem_wait isn't required, the order is enforced by gem_execbuf followed
> by gem_read or subsequent gem_set_domain (if using mmap interface).
> The API is geared towards explicit domain management.
> -Chris
Ok, done that. Will post a new version after you have had a chance to look
at the version I just posted.
Peter.
>
>
--
Peter Antoine (Android Graphics Driver Software Engineer)
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
More information about the Intel-gfx
mailing list