[Intel-gfx] [PATCH] drm/i915/opregion: remove unnecessary ifdefs on CONFIG_ACPI

Jani Nikula jani.nikula at intel.com
Tue Apr 12 12:20:08 UTC 2016


On Tue, 12 Apr 2016, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Fri, Apr 08, 2016 at 05:59:49PM +0300, Jani Nikula wrote:
>> The whole file is ignored on CONFIG_ACPI=n.
>
> That's an issue as we can't then acquire the opregion->vbt (which itself
> is not acpi dependent). Shrug no modern system can boot without acpi (at
> least not if you want more than cpu etc), so I guess we also don't care
> that much?

Interesting, I thought we shouldn't touch ACPI OpRegion for
CONFIG_ACPI=n, but seems that this was changed only in

commit 27d50c82714f6477ac690034b37d202f76eb4f70
Author: Lv Zheng <lv.zheng at intel.com>
Date:   Fri Dec 6 16:52:05 2013 +0800

    ACPI / i915: Fix incorrect <acpi/acpi.h> inclusions via <linux/acpi_io.h>

So this patch here doesn't change the fact, and since there hasn't been
complaints after the above commit, I wouldn't worry too much.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list