[Intel-gfx] [PATCH 2/2] drm/atomic-helper: Print an error if vblank wait times out

[Daniel Vetter]

On Mon, Apr 18, 2016 at 02:29:33PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Vblank waits timing out is no a normal thing to happen, so let's inform
> people when it happens.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Applied to drm-misc, let's see how much it blows up. We /should/ be
filtering out entirely defunct vblank implementations already by checking
vblank_get() ...
-Daniel

> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 7bf678ee7f81..40c7b268a9bc 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -1103,6 +1103,8 @@ drm_atomic_helper_wait_for_vblanks(struct drm_device *dev,
>  					drm_crtc_vblank_count(crtc),
>  				msecs_to_jiffies(50));
>  
> +		WARN(!ret, "[CRTC:%d] vblank wait timed out\n", crtc->base.id);
> +
>  		drm_crtc_vblank_put(crtc);
>  	}
>  }
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch