[Intel-gfx] [PATCH 19/19] drm/i915: Allow async update of pageflips.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Tue Apr 19 12:26:23 UTC 2016


Op 19-04-16 om 10:19 schreef Chris Wilson:
> On Tue, Apr 19, 2016 at 09:52:39AM +0200, Maarten Lankhorst wrote:
>
> If you think it's ready:
> 	dev->mode_config.async_page_flip = true;
> -Chris
>
Oh indeed!

It seems the flag has 2 meanings though, not compatible with each other.

First one is for the DRM_MODE_PAGE_FLIP_ASYNC flag in the legacy page flip handler.
This won't work with the atomic helper because it returns -EINVAL on that flag.
The helper will still do an async atomic commit, however..

Other place is for the atomic ioctl, which will reject it right away if async flag is set but this flag isn't.
However I'm not sure this is correct, looks to me like the atomic_commit hook should reject it like i915 does.

~Maarten


More information about the Intel-gfx mailing list