[Intel-gfx] [PATCH 10/19] drm/i915: Rearrange switch_context to load the aliasing ppgtt on first use

[Chris Wilson]

On Thu, Apr 21, 2016 at 09:48:36AM +0300, Joonas Lahtinen wrote:
> On ke, 2016-04-20 at 19:42 +0100, Chris Wilson wrote:
> >  static bool
> > -needs_pd_load_pre(struct intel_engine_cs *engine, struct intel_context *to)
> > +needs_pd_load_pre(struct i915_hw_ppgtt *ppgtt,
> > +		  struct intel_engine_cs *engine,
> > +		  struct intel_context *to)
> >  {
> > -	if (!to->ppgtt)
> > +	if (ppgtt == NULL)
> 
> Code checker will scream and ask for !ppgtt. And I'm pretty sure we
> should not keep flip-flopping between two styles. Also, you're not
> doing != NULL either to check if pointer is not NULL, but just if
> (foo), so I do not see why to avoid if (!foo).

I normally do do != NULL :(

Oh, well. I give in. Can I also stop writing NULL everywhere and just
use 0 in pointer contexts?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre