[Intel-gfx] [PATCH v7 2/8] drm/i915: Removed now redudant parameter to i915_gem_request_completed()

John Harrison John.C.Harrison at Intel.com
Thu Apr 21 10:18:26 UTC 2016


On 21/04/2016 08:19, Maarten Lankhorst wrote:
> Typo in subject (redundant). ^
>
> Op 20-04-16 om 19:09 schreef John.C.Harrison at Intel.com:
>> From: John Harrison <John.C.Harrison at Intel.com>
>>
>> The change to the implementation of i915_gem_request_completed() means
>> that the lazy coherency flag is no longer used. This can now be
>> removed to simplify the interface.
>>
>> v6: Updated to newer nightly and resolved conflicts.
>>
>> v7: Updated to newer nightly (lots of ring -> engine renaming).
>>
> I think it would be more readable to put this patch as preparation for patch 1.
>
> ~Maarten
I can't be prep for patch one. It is a result of patch one that the 
parameter is redundant and can be removed. It can't be removed before 
the patch that makes it redundant! It could be squashed into that patch 
but earlier comments have been that it is best to not do too much in a 
single patch.



More information about the Intel-gfx mailing list