[Intel-gfx] [PATCH i-g-t 4/7] lib/igt_kms: Only move the in cursor plane for Intel hw.

[Tomeu Vizoso]

On 20 April 2016 at 16:59,  <robert.foss at collabora.com> wrote:
> From: Robert Foss <robert.foss at collabora.com>
>
> Avoid moving the cursor plane when on non-intel hardware.
> Running the move block on hardware with more than IGT_PLANE_CURSOR
> number of planes causes planes do be zeroed out.
>
> Signed-off-by: Robert Foss <robert.foss at collabora.com>
> ---
>  lib/igt_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 3f953ec..522ede5 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1363,7 +1363,7 @@ void igt_display_init(igt_display_t *display, int drm_fd)
>                          * only 1 sprite, that's the wrong slot and we need to
>                          * move it down.
>                          */
> -                       if (p != IGT_PLANE_CURSOR) {
> +                       if (IS_INTEL(drm_fd) && p != IGT_PLANE_CURSOR) {

IS_INTEL takes a devid, not a fd, and its meaning is that the devid
corresponds to known hardware made by Intel.

In this case we probably want to know if the DRM driver is i915, and
for that you have is_i915_device(fd).

Regards,

Tomeu

>                                 pipe->planes[p] = pipe->planes[IGT_PLANE_CURSOR];
>                                 pipe->planes[p].index = p;
>                                 memset(&pipe->planes[IGT_PLANE_CURSOR], 0,
> --
> 2.5.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx