[Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Apr 22 14:41:55 UTC 2016


From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

I would argue it is enough to test one pipe in the BAT set.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
 tests/kms_pipe_crc_basic.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 4de53bc77a3a..291775934758 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -180,6 +180,9 @@ static void test_read_crc(data_t *data, int pipe, unsigned flags)
 
 data_t data = {0, };
 
+#define test_prefix(i) ((i) == 0 ? "basic-" : "")
+#define pipe_name(i) ((i) + 'A')
+
 igt_main
 {
 	igt_skip_on_simulation();
@@ -196,39 +199,39 @@ igt_main
 		igt_display_init(&data.display, data.drm_fd);
 	}
 
-	igt_subtest("bad-pipe")
+	igt_subtest("basic-bad-pipe")
 		test_bad_command(&data, "pipe D none");
 
-	igt_subtest("bad-source")
+	igt_subtest("basic-bad-source")
 		test_bad_command(&data, "pipe A foo");
 
-	igt_subtest("bad-nb-words-1")
+	igt_subtest("basic-bad-nb-words-1")
 		test_bad_command(&data, "pipe foo");
 
-	igt_subtest("bad-nb-words-3")
+	igt_subtest("basic-bad-nb-words-3")
 		test_bad_command(&data, "pipe A none option");
 
 	for (int i = 0; i < 3; i++) {
-		igt_subtest_f("read-crc-pipe-%c", 'A'+i)
+		igt_subtest_f("%sread-crc-pipe-%c", test_prefix(i), pipe_name(i))
 			test_read_crc(&data, i, 0);
 
-		igt_subtest_f("read-crc-pipe-%c-frame-sequence", 'A'+i)
+		igt_subtest_f("%sread-crc-pipe-%c-frame-sequence", test_prefix(i), pipe_name(i))
 			test_read_crc(&data, i, TEST_SEQUENCE);
 
-		igt_subtest_f("nonblocking-crc-pipe-%c", 'A'+i)
+		igt_subtest_f("%snonblocking-crc-pipe-%c", test_prefix(i), pipe_name(i))
 			test_read_crc(&data, i, TEST_NONBLOCK);
 
-		igt_subtest_f("nonblocking-crc-pipe-%c-frame-sequence", 'A'+i)
+		igt_subtest_f("%snonblocking-crc-pipe-%c-frame-sequence", test_prefix(i), pipe_name(i))
 			test_read_crc(&data, i, TEST_SEQUENCE | TEST_NONBLOCK);
 
-		igt_subtest_f("suspend-read-crc-pipe-%c", 'A'+i) {
+		igt_subtest_f("%ssuspend-read-crc-pipe-%c", test_prefix(i), pipe_name(i)) {
 			igt_skip_on(i >= data.display.n_pipes);
 			igt_system_suspend_autoresume();
 
 			test_read_crc(&data, i, 0);
 		}
 
-		igt_subtest_f("hang-read-crc-pipe-%c", 'A'+i) {
+		igt_subtest_f("%shang-read-crc-pipe-%c", test_prefix(i), pipe_name(i)) {
 			igt_hang_ring_t hang =
 				igt_hang_ring(data.drm_fd, I915_EXEC_RENDER);
 			test_read_crc(&data, i, 0);
-- 
1.9.1



More information about the Intel-gfx mailing list