[Intel-gfx] [PATCH xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails

Timo Aaltonen tjaalton at ubuntu.com
Mon Apr 25 08:38:09 UTC 2016


22.04.2016, 21:04, Hans de Goede kirjoitti:
> The probe functions in intel_module.c call intel_open_device() before
> calling intel_scrn_create(), but if the later fails because of e.g.
> an unsupported (new) pci-id they were not cleaning up the resources
> claimed by intel_open_device(), esp. leaking the fd is a problem
> because this breaks the fallback to the modesetting driver.
> 
> This commit fixes this by adding a intel_close_device() cleanup
> function and calling that when intel_scrn_create() fails.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Thanks, fixed the fallback here too.


-- 
t


More information about the Intel-gfx mailing list