[Intel-gfx] [PATCH] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

Chris Wilson chris at chris-wilson.co.uk
Tue Apr 26 09:31:34 UTC 2016


On Tue, Apr 26, 2016 at 10:08:07AM +0100, Matthew Auld wrote:
> If we are not in FULL_48BIT_PPGTT mode then we really shouldn't
> continue on with our allocations, given that the call to free_pdp would
> bail early without freeing everything, thus leaking memory.

Why? Why are you second guessing the caller who asked for a
i915_page_directory struct to be allocated? Is there any reason for a
warn here?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list