[Intel-gfx] [PATCH 04/35] drm: Forbid legacy MAP functions for DRIVER_MODESET

[Daniel Vetter]

On Wed, Apr 27, 2016 at 08:46:31AM +0200, Daniel Vetter wrote:
> On Tue, Apr 26, 2016 at 05:35:42PM -0400, Alex Deucher wrote:
> > On Tue, Apr 26, 2016 at 1:29 PM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > > Like in
> > >
> > > commit 0e975980d435d58df2d430d688b8c18778b42218
> > > Author: Peter Antoine <peter.antoine at intel.com>
> > > Date:   Tue Jun 23 08:18:49 2015 +0100
> > >
> > >     drm: Turn off Legacy Context Functions
> > >
> > > we need to again make an exception for nouveau, but everyone else
> > > really doesn't need this.
> > >
> > > Cc: Peter Antoine <peter.antoine at intel.com>
> > > Cc: Ben Skeggs <bskeggs at redhat.com>
> > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > 
> > Not really familiar with why nouveau needs this, but the logic seems correct.
> 
> Hm, I thought the referenced commit explained this, but now that I recheck
> it doesn't. I'm not too sure again myself why I thought nouveau needs
> this. The legacy ctx stuff is required because of some old kms nouveau ddx
> that still used that stuff. I thought it also used legacy maps ... I'll
> double check once more.

Ok, nouveau ddx indeed used legacy addmap and friends, but that code is
nuked since 2006. That's 10 years, which is the rule of thumb for when we
can drop support. I'll respin this patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch