[Intel-gfx] [PATCH 04/35] drm: Forbid legacy MAP functions for DRIVER_MODESET

Daniel Vetter daniel at ffwll.ch
Wed Apr 27 07:55:19 UTC 2016


On Wed, Apr 27, 2016 at 05:12:22PM +1000, Dave Airlie wrote:
> >> Hm, I thought the referenced commit explained this, but now that I recheck
> >> it doesn't. I'm not too sure again myself why I thought nouveau needs
> >> this. The legacy ctx stuff is required because of some old kms nouveau ddx
> >> that still used that stuff. I thought it also used legacy maps ... I'll
> >> double check once more.
> >
> > Ok, nouveau ddx indeed used legacy addmap and friends, but that code is
> > nuked since 2006. That's 10 years, which is the rule of thumb for when we
> > can drop support. I'll respin this patch.
> > -Daniel
> 
> Nope,
> 
> commit b1a630b48210d6a3c44994fce1b73273000ace5c
> Author: Dave Airlie <airlied at redhat.com>
> Date:   Wed Nov 7 14:45:14 2012 +1000
> 
>     nouveau: drop DRI1 device open interface.
> 
> Was when it was fixed.

Oh right now I remember, the fun was in the X server, not in the DDX. I'll
amend the original commit message and merge.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list