[Intel-gfx] [PATCH] drm/i915: respect VBT PSR link standby configuration for HSW/BDW.

Rodrigo Vivi rodrigo.vivi at intel.com
Wed Apr 27 15:47:54 UTC 2016


We have in the history some changes on this behaviour, but
there are many platforms out there and we don't know all panels.

VBT might not be reliable but it knows the platform better than
us usually. Or at least it should.
So, first of all let's respect the VBT. If something bad happens
again with one platform or another it is better to create a
quirk than to bypass the VBT.

Cc: Mihai Dontu <mihai.dontu at gmail.com>
Cc: Jani Nikula <jani.nikula at intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index c3abae4..e65e2c3 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -788,14 +788,11 @@ void intel_psr_init(struct drm_device *dev)
 	}
 
 	/* Set link_standby x link_off defaults */
-	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
-		/* HSW and BDW require workarounds that we don't implement. */
-		dev_priv->psr.link_standby = false;
 	else if (IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev))
 		/* On VLV and CHV only standby mode is supported. */
 		dev_priv->psr.link_standby = true;
 	else
-		/* For new platforms let's respect VBT back again */
+		/* For other platforms let's respect VBT back again */
 		dev_priv->psr.link_standby = dev_priv->vbt.psr.full_link;
 
 	/* Override link_standby x link_off defaults */
-- 
2.4.3



More information about the Intel-gfx mailing list