[Intel-gfx] [PATCH 07/21] drm/i915/slpc: If using SLPC, do not set frequency

[Chris Wilson]

On Wed, Apr 27, 2016 at 06:10:51PM -0700, tom.orourke at intel.com wrote:
> From: Tom O'Rourke <Tom.O'Rourke at intel.com>
> 
> When frequency requests are made by SLPC, host driver
> should not attempt to make frequency requests due to
> potential conflicts.
> 
> Host-based turbo operations are already avoided when
> SLPC is used.  This change covers other frequency
> requests such as from sysfs or debugfs interfaces.
> 
> A later patch in this series updates sysfs/debugfs
> interfaces for setting max/min frequencies with SLPC.

Since under your scheme, this function is only called from those user
interfaces, why haven't you implemented it here? As the intel_set_* it
is meant to providing the uniform API supporting as many generation as
possible, without having to spread that knowledge around. You have not
explained the API change.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre