[Intel-gfx] [PATCH] drm/i915/execlists: Refactor common engine setup

[Chris Wilson]

On Thu, Apr 28, 2016 at 04:10:54PM +0100, Tvrtko Ursulin wrote:
> >-	/* Intentionally left blank. */
> >-	engine->buffer = NULL;
> >
> >  	engine->dev = dev;
> 
> Setting engine->dev was last in sequence before and now it is ahead
> of lot of other things. I am not sure how important that was and if
> it would cause any trouble now? Especially since using engine->dev
> for intel_ring_initialized is so terribly annoying and bites
> unexpectedly.

Yeah, setting it early allows us to us it earlier! Some of the early
initialisation would like to know engine->dev.

> I still not see a point, maybe it just need to be explained to me.
> :) But anyway will not block it after the above points are addressed
> and discussed.

There wasn't much. All this was so that I could add a couple of lines in
the one place rather than in each caller. I did think it looked a bit
neater and matched the init func well.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre