[Intel-gfx] [PATCH] drm/i915/lvds: do not set border bits when panel fitter is not enabled

[Ville Syrjälä]

On Fri, Apr 29, 2016 at 12:36:35PM +0300, Jani Nikula wrote:
> We also don't read the border bits in i9xx_get_pfit_config() when the
> panel fitter is not enabled, causing the state checker warning:
> 
> [drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in
> gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)
> 
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_panel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index 828f0fcaaaf8..67cf2e22ba51 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -363,6 +363,7 @@ out:
>  	if ((pfit_control & PFIT_ENABLE) == 0) {
>  		pfit_control = 0;
>  		pfit_pgm_ratios = 0;
> +		border = 0;

That doesn't seem right. We especially want the border for "center".

>  	}
>  
>  	/* Make sure pre-965 set dither correctly for 18bpp panels. */
> -- 
> 2.1.4

-- 
Ville Syrjälä
Intel OTC