[Intel-gfx] [PATCH] drm/i915: Protect older gen against intel_gt_init_powersave()

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 2 11:09:40 UTC 2016


On Tue, Aug 02, 2016 at 01:55:48PM +0300, Ville Syrjälä wrote:
> On Tue, Aug 02, 2016 at 11:15:27AM +0100, Chris Wilson wrote:
> > In the middle of intel_gt_init_powersave() we have an if-chain that ends
> > with a universal else clause to read gen6+ registers. Older platforms
> > like Pineview that end up here do not like those registers and may even
> > OOPS whilst reading them!
> > 
> > Fixes: 3a45b05c4517 ("drm/i915: Preserve current RPS frequency across init")
> 
> Shouldn't that be
> Fixes: 773ea9a80132 ("drm/i915: Perform static RPS frequency setup before userspace") ?

Yes, I missed in my grep for the commit marker.

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list