[Intel-gfx] [PATCH i-g-t] igt_kms: Use proper panning coordinates for legacy primary plane updates

Bob Paauwe bob.j.paauwe at intel.com
Wed Aug 3 17:35:15 UTC 2016


On Wed, 3 Aug 2016 09:15:41 -0700
Matt Roper <matthew.d.roper at intel.com> wrote:

> A copy/paste error resulted in us using src_x for both the x and y
> panning coordinates; make sure we use src_y instead for the appropriate
> parameter.
> 
> Fixes: 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Reviewed-by: Bob Paauwe <bob.j.paauwe at intel.com>

> ---
>  lib/igt_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 7d7a53c..ed91688 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
>  		    igt_output_name(output),
>  		    kmstest_pipe_name(pipe->pipe),
>  		    fb_id,
> -		    primary->src_x, primary->src_x,
> +		    primary->src_x, primary->src_y,
>  		    mode->hdisplay, mode->vdisplay);
>  
>  		ret = drmModeSetCrtc(display->drm_fd,
>  				     crtc_id,
>  				     fb_id,
> -				     primary->src_x, primary->src_x,
> +				     primary->src_x, primary->src_y,
>  				     &output->id,
>  				     1,
>  				     mode);



-- 
--
Bob Paauwe                  
Bob.J.Paauwe at intel.com
IOTG / PED Software Organization
Intel Corp.  Folsom, CA
(916) 356-6193    



More information about the Intel-gfx mailing list