[Intel-gfx] [PATCH 06/19] drm/i915: Enable i915_gem_wait_for_idle() without holding struct_mutex

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 5 08:23:42 UTC 2016


On Fri, Aug 05, 2016 at 09:16:21AM +0300, Joonas Lahtinen wrote:
> On to, 2016-08-04 at 20:52 +0100, Chris Wilson wrote:
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -6336,7 +6336,7 @@ bool i915_gpu_busy(void)
> >  	dev_priv = i915_mch_dev;
> >  
> >  	for_each_engine(engine, dev_priv)
> > -		ret |= !list_empty(&engine->request_list);
> > +		ret |= intel_engine_is_active(engine);
> 
> |= always makes me think of bitfields because, well -- it is bitwise
> operation :P
> 
> 		if (intel_engine_is_active(engine))
> 			ret = true;

Ah, this can just die now. And we can use dev_priv->gt.awake instead.
There's a little bit more of a lag, but ips on Ironlake is already a
sore point (and I hope this is not the straw that breaks the camel's
back).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list