[Intel-gfx] [PATCH] drm/i915: Update comment before i915_spin_request

Daniel Vetter daniel.vetter at ffwll.ch
Fri Aug 5 16:11:24 UTC 2016


~jiffie and a few usecs is 3 orders of magnitude different. A bit
much. This was changed in

commit ca5b721e238226af1d767103ac852aeb8e4c0764
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Fri Dec 11 11:32:58 2015 +0000

    drm/i915: Limit the busy wait on requests to 5us not 10ms!

But probably missed the comment since the change was non-local to the
comment.

Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 drivers/gpu/drm/i915/i915_gem_request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index 3fecb8f0e041..1c7307f219f9 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -644,7 +644,7 @@ int i915_wait_request(struct drm_i915_gem_request *req,
 	if (IS_RPS_CLIENT(rps) && INTEL_GEN(req->i915) >= 6)
 		gen6_rps_boost(req->i915, rps, req->emitted_jiffies);
 
-	/* Optimistic spin for the next ~jiffie before touching IRQs */
+	/* Optimistic spin for the next usecs before touching IRQs */
 	if (i915_spin_request(req, state, 5))
 		goto complete;
 
-- 
2.8.1



More information about the Intel-gfx mailing list