[Intel-gfx] [PATCH] drm/i915: Update comment before i915_spin_request

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 5 16:46:47 UTC 2016


On Fri, Aug 05, 2016 at 06:33:38PM +0200, Daniel Vetter wrote:
> On Fri, Aug 05, 2016 at 05:31:25PM +0100, Chris Wilson wrote:
> > On Fri, Aug 05, 2016 at 06:11:24PM +0200, Daniel Vetter wrote:
> > > ~jiffie and a few usecs is 3 orders of magnitude different. A bit
> > > much. This was changed in
> > > 
> > > commit ca5b721e238226af1d767103ac852aeb8e4c0764
> > > Author: Chris Wilson <chris at chris-wilson.co.uk>
> > > Date:   Fri Dec 11 11:32:58 2015 +0000
> > > 
> > >     drm/i915: Limit the busy wait on requests to 5us not 10ms!
> > > 
> > > But probably missed the comment since the change was non-local to the
> > > comment.
> > 
> > No, I was just using it as a pun referring to a jiffy being a small
> > amount of time.
> 
> Too confusing in the context of the linux kernel ;-) Ack?

The comment is not improved by switching in usecs.

/* Optimistic short spin before touching IRQs */

would suffice.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list