[Intel-gfx] [PATCH] drm/i915: Add some curly braces

Pandiyan, Dhinakaran dhinakaran.pandiyan at intel.com
Fri Aug 5 17:52:17 UTC 2016


On Fri, 2016-08-05 at 18:49 +0100, Chris Wilson wrote:
> On Fri, Aug 05, 2016 at 08:41:34PM +0300, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > intel_enable_pipe() looks rather confusing when one side doesn't have
> > the curly braces, and the other one does. And what's even worse,
> > there's another if-else inside the braceless side. Let's put braces
> > around it to make it clear which branch goes where.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Easiest review of the day.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris
> 
I was just about getting started to do my first review!



More information about the Intel-gfx mailing list