[Intel-gfx] [PATCH 17/33] drm/i915: Use VMA directly for checking tiling parameters

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 9 08:03:46 UTC 2016


On Tue, Aug 09, 2016 at 09:18:28AM +0300, Joonas Lahtinen wrote:
> On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > +	return 0;
> > +
> > +bad:
> > +	return i915_vma_unbind(vma);
> 
> Umm, I do not see matching checks to convert to return the error values
> in i915_vma_unbind(). Am I lost or what were you after with this?

The code here is unchanged, just moved so that all the similar checks
were in the same function and mixed between caller and callee.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list