[Intel-gfx] [CI 1/3] drm/i915: Remove unused i915_gem_active_peek_rcu()

Daniel Vetter daniel at ffwll.ch
Wed Aug 10 10:22:35 UTC 2016


On Tue, Aug 09, 2016 at 08:37:00AM +0100, Chris Wilson wrote:
> This was originally introduced to be used by the busy-ioctl, but in the
> end busy ioctl performed a different dance. Since there are no users,
> and no likely users, remove an unwanted chunk of the API.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>

I thought I rubber-stamped this already ...

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_gem_request.h | 21 ---------------------
>  1 file changed, 21 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_request.h b/drivers/gpu/drm/i915/i915_gem_request.h
> index 3496e28785e7..583e237b98d1 100644
> --- a/drivers/gpu/drm/i915/i915_gem_request.h
> +++ b/drivers/gpu/drm/i915/i915_gem_request.h
> @@ -381,27 +381,6 @@ i915_gem_active_peek(const struct i915_gem_active *active, struct mutex *mutex)
>  }
>  
>  /**
> - * i915_gem_active_peek_rcu - report the active request being monitored
> - * @active - the active tracker
> - *
> - * i915_gem_active_peek_rcu() returns the current request being tracked if
> - * still active, or NULL. It does not obtain a reference on the request
> - * for the caller, and inspection of the request is only valid under
> - * the RCU lock.
> - */
> -static inline struct drm_i915_gem_request *
> -i915_gem_active_peek_rcu(const struct i915_gem_active *active)
> -{
> -	struct drm_i915_gem_request *request;
> -
> -	request = rcu_dereference(active->request);
> -	if (!request || i915_gem_request_completed(request))
> -		return NULL;
> -
> -	return request;
> -}
> -
> -/**
>   * i915_gem_active_get - return a reference to the active request
>   * @active - the active tracker
>   *
> -- 
> 2.8.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list