[Intel-gfx] [PATCH 18/33] drm/i915: Use VMA as the primary object for context state

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed Aug 10 10:54:20 UTC 2016


On ke, 2016-08-10 at 09:25 +0100, Chris Wilson wrote:
> On Wed, Aug 10, 2016 at 11:03:39AM +0300, Joonas Lahtinen wrote:
> > 
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > > 
> > > -	if (!i915_gem_obj_ggtt_bound(ctx_obj))
> > > -		seq_puts(m, "\tNot bound in GGTT\n");
> > > -	else
> > > -		ggtt_offset = i915_gem_obj_ggtt_offset(ctx_obj);
> > > +	if (vma->flags & I915_VMA_GLOBAL_BIND)
> > > +		seq_printf(m, "\tBound in GGTT at 0x%x\n",
> > 0x%04x?
> You mean 0x08.
> 

Yep.

This was again rather complex to review, different things being mixed;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list