[Intel-gfx] [PATCH 32/33] drm/i915: Consolidate error object printing

[Joonas Lahtinen]

On ti, 2016-08-09 at 12:53 +0100, Chris Wilson wrote:
> On Tue, Aug 09, 2016 at 02:44:41PM +0300, Joonas Lahtinen wrote:
> > 
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > > @@ -446,15 +458,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
> > >  			err_printf(m, " --- gtt_offset = 0x%08x %08x\n",
> > If intended for userspace parsing "0x%08x %08x" vs. "0x%08x_%08x" would
> > be good to be consistent. And to reduce such error in future, I'd also
> > make this line be printed with above function (let there be extra
> > space).
> Yes, I remembered to fix that mistake only after sending the patches. :|
> 
> Combining this one is a bit trickier as it doesn't conform to the others.
> For simplicity I left the custom header in the caller.

Ack.

> -Chris
> 
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation