[Intel-gfx] [PATCH 29/37] drm/i915: Track pinned VMA

[Joonas Lahtinen]

On pe, 2016-08-12 at 07:54 +0100, Chris Wilson wrote:
> Treat the VMA as the primary struct responsible for tracking bindings
> into the GPU's VM. That is we want to treat the VMA returned after we
> pin an object into the VM as the cookie we hold and eventually release
> when unpinning. Doing so eliminates the ambiguity in pinning the object
> and then searching for the relevant pin later.
> 
> v2: Joonas' stylistic nitpicks, a fun rebase.
> 

<SNIP>

>-	return vma;
>-
> err:
> 	i915_gem_object_unpin_pages(shadow_batch_obj);
>-	if (ret == -EACCES) /* unhandled chained batch */
>-		return NULL;
>-	else
>-		return ERR_PTR(ret);
>+	return vma;
> }

You made it the success path too, so just 'out'.

That's pretty much all I found by scrolling through it;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation