[Intel-gfx] [PATCH 14/37] drm/i915: Track pinned vma inside guc

[Joonas Lahtinen]

CC'ing Dave to comment too.

On pe, 2016-08-12 at 07:54 +0100, Chris Wilson wrote:
>  /**
> - * gem_allocate_guc_obj() - Allocate gem object for GuC usage
> - * @dev_priv:	driver private data structure
> + * guc_allocate_vma() - Allocate a GGTT VMA for GuC usage
> + * @guc:	the guc
>   * @size:	size of object

s/object/VMA/

>   *
>   * This is a wrapper to create a gem obj. In order to use it inside GuC, the
> @@ -624,45 +623,49 @@ static void i915_guc_submit(struct drm_i915_gem_request *rq)
>   *
>   * Return:	A drm_i915_gem_object if successful, otherwise NULL.

s/drm_i915_gem_object/i915_vma/ And maybe update the comment wording
too.

>  /**
> - * gem_release_guc_obj() - Release gem object allocated for GuC usage
> - * @obj:	gem obj to be released
> + * guc_release_vma() - Release gem object allocated for GuC usage
> + * @vma:	gem obj to be released

The GEM object is kinda created implicitly, so not sure how to include
it in wording, improvise.

With the minor tweaks to comments,

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation