[Intel-gfx] [PATCH 33/37] drm/i915: Only record active and pending requests upon a GPU hang

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 12 12:49:45 UTC 2016


On Fri, Aug 12, 2016 at 01:39:34PM +0100, Matthew Auld wrote:
> > +static void engine_record_requests(struct intel_engine_cs *engine,
> > +                                  struct drm_i915_gem_request *first,
> > +                                  struct drm_i915_error_engine *ee)
> > +{
> > +       struct drm_i915_gem_request *request;
> > +       int count;
> > +
> > +       count = 0;
> > +       request = first;
> > +       list_for_each_entry_from(request, &engine->request_list, link)
> > +               count += !!request->batch;
> > +
> > +       ee->requests = NULL;
> > +       kcalloc(count, sizeof(*ee->requests),
> > +               GFP_ATOMIC);
> Surely not Chris :)

Crumbs. Missed that even trying to double check after each iteration.
Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list