[Intel-gfx] [PATCH 16/20] drm/i915: Support to create write combined type vmaps

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 12 15:16:54 UTC 2016


On Fri, Aug 12, 2016 at 08:43:58PM +0530, Goel, Akash wrote:
> On 8/12/2016 4:19 PM, Tvrtko Ursulin wrote:
> >Unreleated and unmentioned change to no guard page. Best to remove IMHO.
> >Can keep the RB in that case.
> 
> Though its not called out, sorry for that, but isn't it better to
> avoid using the guard page, which will save 4KB of vmalloc virtual
> space (which is scarce) for every mapping created by Driver.
> 
> Updating the commit message would be fine to mention about this ?.

Too late, already applied without the new flag.

Yes, that's why I dropped the guard page when I found out it was being
added. Send a patch to add the flag and we can discuss whether we think
our code is adequate to not require the protection.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list