[Intel-gfx] [PATCH 13/20] drm/i915: Augment i915 error state to include the dump of GuC log buffer

[Chris Wilson]

On Fri, Aug 12, 2016 at 09:34:23PM +0530, Goel, Akash wrote:
> 
> 
> On 8/12/2016 9:22 PM, Chris Wilson wrote:
> >On Fri, Aug 12, 2016 at 09:16:03PM +0530, Goel, Akash wrote:
> >>On 8/12/2016 9:02 PM, Chris Wilson wrote:
> >>>There's (or will be) a function to dump the error object in a uniform
> >>>manner. This patch is obsolete.
> >>
> >>There is a print_error_obj() function, but that prints one dword per line.
> >
> >It used to. It will shortly be a compressed stream.
> 
> >Pretty printing is left to userspace.
> But invariably, we only will be interpreting the error state or Guc
> log buffer dump, and it will be really convenient if we can have 4
> dwords per line matching the log sample size.

That's fine. Do it in userspace.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre