[Intel-gfx] [PATCH 12/22] drm/i915: Allocate rings from stolen

[Joonas Lahtinen]

On ti, 2016-08-16 at 11:42 +0100, Chris Wilson wrote:
> @@ -1949,10 +1949,8 @@ intel_ring_create_vma(struct drm_i915_private *dev_priv, int size)
>  	struct drm_i915_gem_object *obj;
>  	struct i915_vma *vma;
>  
> -	obj = ERR_PTR(-ENODEV);
> -	if (!HAS_LLC(dev_priv))
> -		obj = i915_gem_object_create_stolen(&dev_priv->drm, size);
> -	if (IS_ERR(obj))

This previous test should have been IS_ERR_OR_NULL() causing the
fallback to normal path has not worked on LLC platforms.

> +	obj = i915_gem_object_create_stolen(&dev_priv->drm, size);
> +	if (obj == NULL)

!obj

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation