[Intel-gfx] [PATCH 05/22] drm/i915: Pin the pages first in shmem prepare read/write

[Joonas Lahtinen]

On ti, 2016-08-16 at 13:02 +0100, Chris Wilson wrote:
> On Tue, Aug 16, 2016 at 02:57:15PM +0300, Joonas Lahtinen wrote:
> > 
> > On ti, 2016-08-16 at 11:42 +0100, Chris Wilson wrote:
> > > 
> > > @@ -622,6 +622,12 @@ int i915_gem_obj_prepare_shmem_read(struct drm_i915_gem_object *obj,
> > >  	if (ret)
> > >  		return ret;
> > >  
> > > +	ret = i915_gem_object_get_pages(obj);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	i915_gem_object_pin_pages(obj);
> > The pin_pages function is now mustcheck (or I'm lost between series),
> > so;
> We haven't yet applied the get/pin pages API changes yet.
> 
> I've penciled those in for later when splitting out a lock for the
> backing storage. Other people may want the changes earlier?

Then the code should be fine as is. You can add my R-b.

Regards, Joonas

> -Chris
> 
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation