[Intel-gfx] [PATCH 6/9] drm/i915/cmdparser: Compare against the previous command descriptor

Matthew Auld matthew.william.auld at gmail.com
Wed Aug 17 07:55:53 UTC 2016


>> > -       default_desc->flags = CMD_DESC_SKIP;
>> > +       default_desc->cmd.value = cmd_header;
>> > +       default_desc->cmd.mask = 0xffff0000;
>> Where did you pluck this mask from?
>
> It is the most general cmd header mask.
>
>         #define MIN_OPCODE_SHIFT 16
>         cmd.mask = ~0u << MIN_OPCODE_SHIFT
> ?
Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-gfx mailing list