[Intel-gfx] [PATCH 2/2] drm/i915/error: capture errored context based on request context-id

Dave Gordon david.s.gordon at intel.com
Thu Aug 18 16:56:01 UTC 2016


On 11/08/16 17:43, Chris Wilson wrote:
> On Thu, Aug 11, 2016 at 05:09:01PM +0100, Arun Siluvery wrote:
>> From: Dave Gordon <david.s.gordon at intel.com>
>>
>> Context capture hasn't worked for a while now, since the introduction of
>> execlists because the function that records active context is using CCID
>> register but this register contents are not valid in Execlist mode; this
>> patch makes it work again by using a different way of identifying the
>> context of interest in execlist mode.
>
> Bzzt. The contexts are stored in the request and the iteration here is
> still unsafe.
> -Chris

This patch didn't add any iteration, so any unsafe iteration was already 
there.

All this did was change the matching criterion for which context is the 
one interesting one, by matching on the relevant parts of the "active 
context descriptor" rather than only the (obsolete) CCID register.

.Dave.


More information about the Intel-gfx mailing list