[Intel-gfx] [PATCH v7] drm/i915/execlists: Move WA_TAIL_DWORDS to callee

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 19 13:39:42 UTC 2016


On Fri, Aug 19, 2016 at 02:31:15PM +0100, Dave Gordon wrote:
> @@ -654,6 +680,14 @@ int intel_logical_ring_alloc_request_extras(struct drm_i915_gem_request *request
>  	 */
>  	request->reserved_space += EXECLISTS_REQUEST_SIZE;
>  
> +	/*
> +	 * WA_TAIL_DWORDS is specific to the execlist submission mechanism,
> +	 * to accommodate some NOOPs at the end of each request, to be used
> +	 * by a workaround for not being allowed to do lite restore with
> +	 * HEAD==TAIL (WaIdleLiteRestore). See intel_logical_ring_submit()
> +	 */
> +	request->reserved_space += sizeof(u32) * WA_TAIL_DWORDS(request);

We already have the define that accommodates the tail. Whilst this
remains a fixed size, let's use it appropriately. And when it is
dynamic, we store it in the engine (or context).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list