[Intel-gfx] [PATCH 2/4] drm/i915: Simplify ELSP queue request tracking

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 23 14:51:53 UTC 2016


On Tue, Aug 23, 2016 at 05:28:07PM +0300, Mika Kuoppala wrote:
> > +	/* Try to read in pairs and fill both submission ports */
> > +	spin_lock(&engine->execlist_lock);
> > +	list_for_each_entry(cursor, &engine->execlist_queue, execlist_link) {
> > +		if (last && !merge_ctx(cursor->ctx, last->ctx)) {
> > +			if (port != engine->execlist_port)
> > +				break;
> 
> In here you will merge ctx also for the second port?
>
> The previous version of the code was careful to only merge for
> the first port/request.

Careful? Hah.
-Chris
 
-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list